Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): return proper repository #1333

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

dineshsalunke
Copy link
Contributor

check if the entity has tree metadata and return a tree repository if it exists

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently the providers don't return a TreeRepository for tree entities.

What is the new behavior?

Now the provider will create and return a tree repository for tree entities

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

check if the entity has tree metadata and return a tree repository if it exists
@dineshsalunke
Copy link
Contributor Author

@kamilmysliwiec any update ?

@Kisama
Copy link

Kisama commented Jul 12, 2022

I am waiting this PR is merged

@dineshsalunke
Copy link
Contributor Author

@micalevisk @kamilmysliwiec any plans on merging this PR ?

@micalevisk
Copy link
Member

you can use patch-package until the merge

I don't have permissions to merge PRs

@dineshsalunke
Copy link
Contributor Author

@micalevisk we are already using patch-package for this, but that's not the ideal thing

@dineshsalunke
Copy link
Contributor Author

@kamilmysliwiec any idea if this can be merged or not ?

@kamilmysliwiec kamilmysliwiec merged commit 249edca into nestjs:master Aug 11, 2022
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants