Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5G as an option to the Cellular device interface section #15603

Closed
KPTheProf opened this issue Apr 3, 2024 · 4 comments · Fixed by #15677
Closed

Add 5G as an option to the Cellular device interface section #15603

KPTheProf opened this issue Apr 3, 2024 · 4 comments · Fixed by #15677
Assignees
@Julio-Oliveira-Encora
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@KPTheProf
Copy link

KPTheProf commented Apr 3, 2024 •
edited by jeremystretch

NetBox version

v3.7.4

Feature type

Change to existing functionality

Proposed functionality

With reference to Interface Type Additions for LTE Standards #2866 could we add 5G to list of cellular interface types to differentiate those devices that support 5G as apposed to 4G/LTE.

Use case

We are rolling out Cradlepoint W1850 5G devices and would like to differentiate 5G devices from older LTE models.

Database changes

No response

External dependencies

No response
@KPTheProf KPTheProf added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Apr 3, 2024
@KPTheProf KPTheProf changed the title Add 5G as an option to the Celluar section when creating device interfaces Add 5G as an option to the Cellular device interface section Apr 3, 2024
@abhi1693 abhi1693 added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 5, 2024
@abhi1693 abhi1693 removed their assignment Apr 5, 2024
@Julio-Oliveira-Encora
Copy link
Contributor

Could you please assign this task to me?

@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 9, 2024
Merged
@jeremystretch
Copy link
Member

This needs more discussion before it can be accepted. Is there consensus that adding a single "5G" type is sufficient? Concern was raised in #2866 that adding a single generic "LTE" type would be limiting. I'm not sure that's come up again more recently, but we should give this proposal the same consideration.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Apr 10, 2024
@RasmusThing
Copy link

This needs more discussion before it can be accepted. Is there consensus that adding a single "5G" type is sufficient? Concern was raised in #2866 that adding a single generic "LTE" type would be limiting. I'm not sure that's come up again more recently, but we should give this proposal the same consideration.

I agree - and what about 4G?
4G and LTE networks are not the same. LTE came out before 4G to offer a slightly better speed and performance than its predecessor, 3G. Later, LTE-A emerged and delivered an even higher performance, which is almost as good as the real 4G.

@KPTheProf
Copy link
Author

KPTheProf commented Apr 22, 2024 •
edited

I agree - and what about 4G? 4G and LTE networks are not the same. LTE came out before 4G to offer a slightly better speed and performance than its predecessor, 3G. Later, LTE-A emerged and delivered an even higher performance, which is almost as good as the real 4G.

I'm quite happy accept adding both 4G and 5G, we were initially using LTE as there was no 4G device type.

jeremystretch pushed a commit that referenced this issue May 21, 2024
@Julio-Oliveira-Encora
Fixes #15603 - Added 5G to Cellular choices in dcim/choices.py. (#15677)
b0520b9 
* Added 5G to Cellular choices in dcim/choices.py.

* Added 4G for Cellular choices.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels May 21, 2024
jeremystretch added a commit that referenced this issue May 21, 2024
@jeremystretch
Changelog for #13764, #14653, #15082, #15603, #15962, #16164, #16173, #…
97f8f94 
…16228
@jeremystretch jeremystretch mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julio-Oliveira-Encora Julio-Oliveira-Encora

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #15603 - Added 5G to Cellular choices in dcim/choices.py. Julio-Oliveira-Encora/netbox
6 participants
@arthanson @abhi1693 @RasmusThing @jeremystretch @KPTheProf @Julio-Oliveira-Encora