Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the "Related Objects" pane of all models dynamic #15794

Open
alehaa opened this issue Apr 20, 2024 · 2 comments · May be fixed by #15876
Open

Make the "Related Objects" pane of all models dynamic #15794

alehaa opened this issue Apr 20, 2024 · 2 comments · May be fixed by #15876
Assignees
@alehaa
Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@alehaa
Copy link
Contributor

alehaa commented Apr 20, 2024

NetBox version

v3.7.5

Feature type

Change to existing functionality

Proposed functionality

In #13794, extending the "Related Objects" by other showing other models was requested and implemented by dynamically listing counts for all ManyToMany reverse relationships. Now, I'd like to copy this functionality to all other uses of the "Related Objects" pane,

Use case

As described in #13794, it might be useful for plugins to link their data to existing NetBox core models. However, this is not only useful for tenancy, but any object relationship could benefit from this.

A real life example is covered by the NetBox inventory plugin: Hardware assets are related to dcim.Device, dcim.Manufacturer, dcim.Site and dcim.Location. They would benefit from quick access to a list of related assets for these models. Right now an extra pane needs to be implemented, so there are actually two "Related Objects" panes per details page.

Also, this would make this feature work consistently across all views in NetBox, so the maintenance overhead should theoretically be reduced.

Database changes

None

External dependencies

None
@alehaa alehaa added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Apr 20, 2024
@alehaa
Copy link
Contributor Author

alehaa commented Apr 20, 2024 •
edited

I've already tested using the code from TenantView in other views and can provide a PR for the changes requested.

@arthanson arthanson added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 22, 2024
@arthanson arthanson removed their assignment Apr 22, 2024
@arthanson
Copy link
Collaborator

@alehaa sounds good, I'll assign to you - Note: you should capture the existing logic into a reusable function (vs. copying and pasting the current get_extra_context() for TenantView)

@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Apr 22, 2024
alehaa added a commit to alehaa/netbox that referenced this issue Apr 28, 2024
@alehaa
Closes netbox-community#15794: Make "related objects" dynamic
78f741f 
Instead of hardcoding relationships between models for the detail view,
they are now dynamically generated.
@alehaa alehaa linked a pull request Apr 28, 2024 that will close this issue
Open
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Closed
@jeremystretch jeremystretch added the complexity: medium Requires a substantial but not unusual amount of effort to implement label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alehaa alehaa

Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

15794 Make "related objects" dynamic alehaa/netbox
3 participants
@arthanson @alehaa @jeremystretch