add ENABLE_TRANSLATION setting to optionally turn translation off #16096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyasnikov
force-pushed
the
16055-turnoff-translation
branch
from
bfd03da
to
c323c62
Compare
jeremystretch
requested changes
May 13, 2024
There was a problem hiding this comment.
While this implements the root translation control, it does not address UX: A user can still change his or her language, and would naturally assume that preference to have an effect. Please extend the PR to also disable the user's language preference when translation has been disabled (or at a minimum indicate as much to the user).
amyasnikov
force-pushed
the
16055-turnoff-translation
branch
from
61cc269
to
c519817
Compare
|
@jeremystretch fixed, pls take a look 
|
amyasnikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16055