Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move model feature registration out of netbox.models.features #16058

Open
jeremystretch opened this issue May 9, 2024 · 0 comments
Open

Move model feature registration out of netbox.models.features #16058

jeremystretch opened this issue May 9, 2024 · 0 comments
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move the register_models() utility function out of netbox.models.features to a location TBD.

Justification

register_models() requires utilities.views.register_model_view(). This leads to a circular import when attempting to import netbox.models.features from within users.models because register_model_view() must ultimately resolve the User model (see PR #15976).
@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 9, 2024
@jeremystretch jeremystretch mentioned this issue May 9, 2024
Open
This was referenced May 21, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch