Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current NetBox version in the PluginConfig.validate() error output #16090

Closed
markkuleinio opened this issue May 11, 2024 · 1 comment · Fixed by #16094
Closed

Add current NetBox version in the PluginConfig.validate() error output #16090

markkuleinio opened this issue May 11, 2024 · 1 comment · Fixed by #16094
Assignees
@markkuleinio
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@markkuleinio
Copy link
Contributor

NetBox version

v4.0.1

Feature type

New functionality

Proposed functionality

When PluginConfig.validate() determines that the current NetBox version does not meet the plugin requirements, also print out the current NetBox version in the exception message.

Use case

Currently the error message only prints the version that the plugin mandates, but due to possible installation directory confusion it would be good to also print the current NetBox version. Example case: #16088

Database changes

None

External dependencies

None
@markkuleinio markkuleinio added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 11, 2024
@markkuleinio
Copy link
Contributor Author

If this is accepted, I can send the PR.

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 12, 2024
@abhi1693 abhi1693 assigned markkuleinio and unassigned arthanson May 12, 2024
markkuleinio added a commit to markkuleinio/netbox that referenced this issue May 12, 2024
@markkuleinio
Closes netbox-community#16090: Show NetBox version if plugin validati…
db578bc 
…on fails
@markkuleinio markkuleinio mentioned this issue May 12, 2024
Merged
jeremystretch added a commit that referenced this issue May 13, 2024
@markkuleinio @jeremystretch
Closes #16090: Show NetBox version if plugin validation fails (#16094)
4b91e79 
* Closes #16090: Show NetBox version if plugin validation fails

* Shorten error message

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch added a commit that referenced this issue May 13, 2024
@jeremystretch
Changelog for #15119, #16077, #16078, #16090, #16101
b67eda4
@jeremystretch jeremystretch mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markkuleinio markkuleinio

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16090: Show NetBox version if plugin validation fails markkuleinio/netbox
3 participants
@arthanson @abhi1693 @markkuleinio