Fail to install netlify cli action

[Wyfy0107]

We're using this action in ubuntu-latest environment, with node 12.x
The installation failed with some weird logs below

[bogdibota]

got the same error

it's caused by this Marak/colors.js@074a0f8

[sawa-zen]

npm seems to have removed the problematic version of colors.js, so I think it's working now!

[AdrienFromToulouse]

👋 I think it does not completely solve the issue. The build is ok BUT the deploy now fails silently with RangeError: Invalid array length.

Do you confirm the same issue?

update ok sorry, this fix is not yet on master.

[sawa-zen]

Oops. I was experiencing the same problem 😵‍💫 I'm sorry I didn't notice.

[AdrienFromToulouse]

Although it seems that moving to npm will introduce another issue of access right during the build:

netlify/cli#1870

do you reproduce on your CI too?

[AdrienFromToulouse]

For instance I tried that branch which implements the fix uses: mannum/netlify-actions/cli@master and face the issue

https://github.com/mannum/netlify-actions/blob/master/cli/Dockerfile#L12

I am running on runs-on: ubuntu-latest

[AdrienFromToulouse]

Oops. I was experiencing the same problem 😵‍💫 I'm sorry I didn't notice.

I think you are still using yarn, but the package has been somehow "removed" to not create anymore issues. This seems to be a side effect.

[sawa-zen]

OK. I'll try mannum/netlify-actions too.

[AdrienFromToulouse]

It would be nice if the Netlify team could maintain this and put that into their OKRs, especially for paid customer.
#rant

[AdrienFromToulouse]

I found it, that requires to upgrade the node version of the image to the most recent if we want to use npm:
netlify/cli#1870 (comment)

Their version is still node 12 on master.

[Wyfy0107]

@AdrienFromToulouse Just to be sure, the current fix would be to use mannum/netlify-actions with node latest ?

[AdrienFromToulouse]

I don't know why with Yarn it keeps failing but using npm you need a recent version of node/npm. Works on my end with

FROM node:16-alpine

LABEL version="1.0.1"
LABEL repository="http://github.com/netlify/actions"
LABEL homepage="http://github.com/netlify/actions/netlify"
LABEL maintainer="Netlify"
LABEL "com.github.actions.name"="Netlify"
LABEL "com.github.actions.description"="Wraps the Netlify CLI to enable common Netlify commands"
LABEL "com.github.actions.icon"="cloud"
LABEL "com.github.actions.color"="blue"

RUN npm install -g netlify-cli

COPY entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]

@Wyfy0107 you may just fork netlify action and modify the dockerfile and point to your own fork.

[sawa-zen]

Huh? I can now deploy with netlify/actions/cli@master.

[AdrienFromToulouse]

May be some cache on yarn? idk

[sawa-zen]

I don't know either ¯_(ツ)_/¯

@AdrienFromToulouse
If you try netlify/actions/cli@master now, will it succeed?

[Wyfy0107]

I tried again yesterday and it works now 😅