Skip to content

feat!: return AsyncIterator for list() #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Changes the API for manual pagination in list(). Rather than exposing the concept of cursors, we return an AsyncIterator when the paginate parameter is set to true.

Verified

This commit was signed with the committer’s verified signature.
samueljsb Samuel Searles-Bryant
@eduardoboucas eduardoboucas requested a review from a team as a code owner November 10, 2023 12:43
Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit d37ba51
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/654e2d8a002f720008c0deb9
😎 Deploy Preview https://deploy-preview-102--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 10, 2023
minivan
minivan previously approved these changes Nov 10, 2023
lukasholzer
lukasholzer previously approved these changes Nov 10, 2023
README.md Outdated
@@ -355,6 +355,29 @@ console.log(directories)
Note that we're only interested in entries under the `cats` directory, which is why we're using a trailing slash.
Without it, other keys like `catsuit` would also match.

For performance reasons, the server groups entries into multiple pages with a given size. By default, the `list()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the given size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in d37ba51.

ascorbic
ascorbic previously approved these changes Nov 10, 2023
@eduardoboucas eduardoboucas dismissed stale reviews from ascorbic, lukasholzer, and minivan via d37ba51 November 10, 2023 13:18
@eduardoboucas eduardoboucas merged commit f951513 into main Nov 10, 2023
@eduardoboucas eduardoboucas deleted the feat/async-iterator branch November 10, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants