-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: return AsyncIterator
for list()
#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+241
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
minivan
previously approved these changes
Nov 10, 2023
lukasholzer
previously approved these changes
Nov 10, 2023
ascorbic
reviewed
Nov 10, 2023
README.md
Outdated
@@ -355,6 +355,29 @@ console.log(directories) | |||
Note that we're only interested in entries under the `cats` directory, which is why we're using a trailing slash. | |||
Without it, other keys like `catsuit` would also match. | |||
|
|||
For performance reasons, the server groups entries into multiple pages with a given size. By default, the `list()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the given size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in d37ba51.
ascorbic
previously approved these changes
Nov 10, 2023
d37ba51
minivan
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Changes the API for manual pagination in
list()
. Rather than exposing the concept of cursors, we return anAsyncIterator
when thepaginate
parameter is set totrue
.