Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support list() in local server #83

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Follow-up to #82. Adds support for the list operation to the local server.

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 3e511d3
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/653a86a1106a5c00080832eb
😎 Deploy Preview https://deploy-preview-83--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 26, 2023
@eduardoboucas eduardoboucas marked this pull request as ready for review October 26, 2023 15:40
@eduardoboucas eduardoboucas requested a review from a team as a code owner October 26, 2023 15:40

const fooFightersSongs = await blobs.list({ prefix: 'foo-fighters/' })

expect(fooFightersSongs.blobs).toEqual([])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, nothing but respect for the Foo Fighters.

})
const songs: Record<string, string> = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice playlist

@eduardoboucas eduardoboucas merged commit 9fc8456 into main Oct 26, 2023
@eduardoboucas eduardoboucas deleted the feat/list-local-server branch October 26, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants