Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete status code checking #93

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

cbosss
Copy link
Contributor

@cbosss cbosss commented Nov 7, 2023

When deleting via the edge, a successful status code is 204. We weren't classifying this as successful and throwing errors like:

Nov 6, 10:20:08 PM: cc534af9 ERROR Invoke Error {"errorType":"BlobsInternalError","errorMessage":"Netlify Blobs has generated an internal error: 204 response","name":"BlobsInternalError","stack":["BlobsInternalError: Netlify Blobs has generated an internal error: 204 response"," at _Store.delete (/var/task/node_modules/@netlify/blobs/dist/main.cjs:263:13)"," at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"," at async Object.netliblob_default (/var/task/functions/netliblob.cjs:51:7)"," at async Runtime.handler (file:///var/task/___netlify-bootstrap.mjs:1847:15)"," at async Runtime.handleOnceStreaming (file:///var/runtime/index.mjs:1206:26)"]}

Here's the docs.

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant
@cbosss cbosss requested a review from a team as a code owner November 7, 2023 06:28
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 1e63146
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/6549d90646cdea0008d11e9d
😎 Deploy Preview https://deploy-preview-93--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 7, 2023
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@eduardoboucas eduardoboucas merged commit ea3d754 into main Nov 7, 2023
@eduardoboucas eduardoboucas deleted the cole/delete-status-code branch November 7, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants