Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve serialization of system log input #4414

Merged
merged 2 commits into from Aug 8, 2022
Merged

feat: improve serialization of system log input #4414

merged 2 commits into from Aug 8, 2022

Conversation

eduardoboucas
Copy link
Member

Summary

Contains minor improvements to the serialization mechanism for the systemLog utility input:

  • if the input is an Error, it prints the message and stack trace
  • if serializing to JSON fails, it prints the simple string representation

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 8, 2022
@eduardoboucas eduardoboucas marked this pull request as ready for review August 8, 2022 11:19
@eduardoboucas eduardoboucas requested a review from a team August 8, 2022 13:08
@kodiakhq kodiakhq bot merged commit a873036 into main Aug 8, 2022
@kodiakhq kodiakhq bot deleted the feat/system-log-serialization branch August 8, 2022 13:23
@token-generator-app token-generator-app bot mentioned this pull request Aug 8, 2022
Merged
@netlify-jenkins netlify-jenkins mentioned this pull request Oct 7, 2022
Merged
@netlify-jenkins netlify-jenkins mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danez danez danez approved these changes

Assignees
No one assigned
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @danez