Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide systemLogFile flag from output #4427

Merged
merged 3 commits into from Aug 10, 2022
Merged

fix: hide systemLogFile flag from output #4427

merged 3 commits into from Aug 10, 2022

Conversation

eduardoboucas
Copy link
Member

Summary

There's no reason for user-facing logs to show the systemLogFile introduced in #4406. This PR hides it, unless debug is on.

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Aug 10, 2022
@eduardoboucas eduardoboucas requested review from a team and khendrikse August 10, 2022 13:00
@kodiakhq kodiakhq bot merged commit 1337b1b into main Aug 10, 2022
@kodiakhq kodiakhq bot deleted the feat/hide-systemlogfile-flag branch August 10, 2022 15:10
@token-generator-app token-generator-app bot mentioned this pull request Aug 10, 2022
Merged
@netlify-jenkins netlify-jenkins mentioned this pull request Oct 7, 2022
Merged
@netlify-jenkins netlify-jenkins mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danez danez danez approved these changes

@khendrikse khendrikse Awaiting requested review from khendrikse

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @danez