Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow edge function schema to have a display name #4549

Merged
merged 4 commits into from Oct 3, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Sep 30, 2022

Summary

Allows edge function to have a display name in the manifest

This only changes the validation to allow for this new optional field

For https://github.com/netlify/pod-compute/issues/211


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@danez danez added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 30, 2022
@danez danez requested a review from a team September 30, 2022 06:15
@danez danez added the automerge label Oct 3, 2022
@kodiakhq kodiakhq bot merged commit f737c39 into main Oct 3, 2022
@kodiakhq kodiakhq bot deleted the displayName-edgefunc branch October 3, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants