-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't poll HTTP on startup to prevent dependency cycle between framework dev server and Netlify Dev #5558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing Astro-specific in the issue though. Which other frameworks should do the same?
I guess every framework that might use passthrough requests. Do we have a list of them? |
These are normal Netlify functions or edge functions, so basically any framework. |
Hmm, that feels weird. We have |
Yes, they would all suffer from this. To be clear: it's quite a niche issue, which is why it hasn't come up before afaik. It's a site that calls one of its own functions when rendering the index page via SSR. I'd say that's an anti-pattern, tbh |
We discussed this a bit more in https://linear.app/netlify/issue/COM-550/cannot-boot-ntl-dev-on-astro-project-using-functions-and-edge#comment-4b579375, and there seems to be consensus that there's no reason to check HTTP when polling for the framework server. So I removed the HTTP polling strategy from all frameworks in c84ec68. |
Some overly-specific tests need updating |
Updated them in 2320bf6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the title before merging, to be more specific about what's changed
Summary
Resolves https://linear.app/netlify/issue/COM-550/cannot-boot-ntl-dev-on-astro-project-using-functions-and-edge
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)