Skip to content

fix: update warning message and graph codegen library output #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sgrove
Copy link
Contributor

@sgrove sgrove commented Feb 8, 2022

Summary

Continuing along the graph codegen improvement path


For us to review and ship your PR efficiently, please perform the following steps:

  • Update or add tests (if any source code was changed or added) 🧪
  • Make sure the status checks below are successful ✅

Sorry, something went wrong.

@sgrove sgrove requested a review from erezrokah February 8, 2022 07:14
@sgrove sgrove added the type: bug code to address defects in shipped code label Feb 8, 2022
@sgrove sgrove requested review from anmonteiro and removed request for erezrokah February 8, 2022 07:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@erezrokah
Copy link
Contributor

Going to merge this as the failures are unrelated.

I'd consider the usage of snapshots as the current ones are quite big making it hard to know what had changed.

@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Feb 8, 2022
@kodiakhq kodiakhq bot merged commit 69f6465 into netlify:main Feb 8, 2022
@sgrove
Copy link
Contributor Author

sgrove commented Feb 8, 2022

The snapshots aren't meant to be reviewed by humans right now, the files the tests write to the filesystem are - the tests are just a failsafe. I'll make change to this bit by bit (just as we've added the matrix test and new dimensions), but it'll take some time.

@sgrove
Copy link
Contributor Author

sgrove commented Feb 9, 2022

@erezrokah I updated the format of the snapshot tests in #4239, should be significantly better to read diffs now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants