Skip to content

netlify-cli should respect your decision when you answer "No" to a question #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whitep4nth3r opened this issue Feb 15, 2022 · 1 comment · Fixed by #4316
Closed

netlify-cli should respect your decision when you answer "No" to a question #4303

whitep4nth3r opened this issue Feb 15, 2022 · 1 comment · Fixed by #4316
Labels
good first issue type: bug code to address defects in shipped code

Comments

@whitep4nth3r
Copy link
Contributor

Describe the bug

If you make a typo on the command line and Netlify asks you to confirm your decision, and you reply with "No", Netlify goes ahead and runs a command anyway.

To Reproduce

Steps to reproduce the behavior:

  1. Type netlify ddev or a similar typo
  2. Reply with "No" when Netlify asks "Did you mean dev"
  3. Observe that netlify dev is run anyway

Configuration

System:
    OS: macOS 12.2
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.52 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.3.0 - /opt/homebrew/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.3.0 - /opt/homebrew/bin/npm
  npmGlobalPackages:
    netlify-cli: 8.14.1

Expected behavior

When I answer "No", I expect the CLI not to run.

CLI Output

image

Additional context

This issue might be linked to #2873

@whitep4nth3r whitep4nth3r added good first issue type: bug code to address defects in shipped code labels Feb 15, 2022
@iib0011
Copy link
Contributor

iib0011 commented Feb 16, 2022

solved iib0011@648edc8

erezrokah pushed a commit that referenced this issue Feb 17, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants