fix: graph language #4308

sgrove · 2022-02-15T14:55:01Z

Summary

Fixes language in netlify.toml/graph to be a scalar and not an array, which was causing the wrong language to be emitted for graph handlers

Make sure the status checks below are successful ✅

github-actions · 2022-02-15T14:56:02Z

📊 Benchmark results

Comparing with 8b697d9

Package size: 442 MB

⬇️ 0.00% decrease vs. 8b697d9

^  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  439 MB  442 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (8b697d9): 442 MB
T-29 (62d4e01): 442 MB
T-28 (4e1ca42): 442 MB
T-27 (6212d30): 442 MB
T-26 (d961855): 442 MB
T-25 (fa3980d): 442 MB
T-24 (9754f66): 442 MB
T-23 (2913759): 442 MB
T-22 (050bf90): 442 MB
T-21 (b74c0ee): 442 MB
T-20 (d1577f6): 442 MB
T-19 (1fb1f34): 442 MB
T-18 (05a0e92): 510 MB
T-17 (bd52b3e): 510 MB
T-16 (96446a9): 510 MB
T-15 (f5bd8f2): 509 MB
T-14 (3279dc3): 439 MB
T-13 (0b2d2c9): 439 MB
T-12 (9773787): 439 MB
T-11 (7b6b94a): 439 MB
T-10 (eed5a47): 439 MB
T-9 (5728f74): 439 MB
T-8 (42b4b23): 439 MB
T-7 (1f9ee87): 439 MB
T-6 (9c71bf9): 439 MB
T-5 (3ecfea6): 439 MB
T-4 (5900487): 439 MB
T-3 (a7bf9ad): 439 MB
T-2 (82e60e4): 439 MB
T-1 (aa470b5): 439 MB
T (current commit): 442 MB

erezrokah

Hi @sgrove, left one comment

erezrokah · 2022-02-15T15:10:13Z

src/lib/one-graph/cli-netlify-graph.js

@@ -217,8 +217,7 @@ const getNetlifyGraphConfig = async ({ command, options, settings }) => {
  const moduleType =
    (userSpecifiedConfig.moduleType && userSpecifiedConfig.moduleType.split(path.sep)) ||
    defaultFrameworkConfig.moduleType
-  const language =
-    (userSpecifiedConfig.language && userSpecifiedConfig.language.split(path.sep)) || autodetectedLanguage
+  const language = (userSpecifiedConfig.language && userSpecifiedConfig.language) || autodetectedLanguage


Suggested change

const language = (userSpecifiedConfig.language && userSpecifiedConfig.language) || autodetectedLanguage

const language = userSpecifiedConfig.language || autodetectedLanguage

It seems userSpecifiedConfig.language is duplicated?

Should be fixed!

erezrokah · 2022-02-15T15:22:15Z

@sgrove when you squash merge this PR, make sure to use fix: as the prefix of the commit message to trigger a new release

sgrove added 2 commits February 15, 2022 06:52

fix: graph language should be a scalar

Verified

This commit was signed with the committer’s verified signature.

joakime Joakim Erdfelt

GPG key ID: 2D0E1FB8FE4B68B4

Verified
Learn about vigilant mode

55c9f4d

chore: fix formatting

Verified

This commit was signed with the committer’s verified signature.

joakime Joakim Erdfelt

GPG key ID: 2D0E1FB8FE4B68B4

Verified
Learn about vigilant mode

80d6a92

sgrove self-assigned this Feb 15, 2022

sgrove changed the title ~~Graph fix language~~ fix: fix graph language Feb 15, 2022

sgrove changed the title ~~fix: fix graph language~~ fix: graph language Feb 15, 2022

github-actions bot added the type: bug label Feb 15, 2022

sgrove changed the title ~~fix: graph language~~ chore: graph language Feb 15, 2022

github-actions bot added the type: chore label Feb 15, 2022

sgrove requested a review from erezrokah February 15, 2022 14:56

erezrokah suggested changes Feb 15, 2022

View reviewed changes

chore: address comments

Verified

This commit was signed with the committer’s verified signature.

joakime Joakim Erdfelt

GPG key ID: 2D0E1FB8FE4B68B4

Verified
Learn about vigilant mode

ef1126b

erezrokah approved these changes Feb 15, 2022

View reviewed changes

erezrokah changed the title ~~chore: graph language~~ fix: graph language Feb 15, 2022

erezrokah enabled auto-merge (squash) February 15, 2022 15:27

erezrokah merged commit f8e1953 into main Feb 15, 2022

erezrokah deleted the graph-fix-language branch February 15, 2022 15:30

token-generator-app bot mentioned this pull request Feb 15, 2022

chore(main): release 9.6.2 #4309

Merged

token-generator-app bot mentioned this pull request May 26, 2022

chore(main): release 10.3.3 #4629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: graph language #4308

fix: graph language #4308

sgrove commented Feb 15, 2022

github-actions bot commented Feb 15, 2022 •

edited

Loading

erezrokah left a comment

erezrokah Feb 15, 2022

sgrove Feb 15, 2022

erezrokah commented Feb 15, 2022 •

edited

Loading

	const language = (userSpecifiedConfig.language && userSpecifiedConfig.language) \|\| autodetectedLanguage
	const language = userSpecifiedConfig.language \|\| autodetectedLanguage

fix: graph language #4308

fix: graph language #4308

Conversation

sgrove commented Feb 15, 2022

Summary

github-actions bot commented Feb 15, 2022 • edited Loading

📊 Benchmark results

Package size: 442 MB

erezrokah left a comment

Choose a reason for hiding this comment

erezrokah Feb 15, 2022

Choose a reason for hiding this comment

sgrove Feb 15, 2022

Choose a reason for hiding this comment

erezrokah commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

erezrokah commented Feb 15, 2022 •

edited

Loading