Skip to content

feat(command-deploy): allow support for deploying by site name #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 1, 2022

Conversation

tinfoil-knight
Copy link
Contributor

@tinfoil-knight tinfoil-knight commented Feb 18, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #3033
Fixes #157

Currently deploying a specific directory to a site on netlify requires looking up the site id and providing it as netlify deploy --site <very-long-id>. Site Ids aren't very memorizable or readable.

This PR adds support for deploying sites by their names like netlify deploy --site my-first-site.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

Sorry, something went wrong.

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 19, 2022
@tinfoil-knight tinfoil-knight requested a review from a team as a code owner February 21, 2022 06:51
@tinfoil-knight tinfoil-knight force-pushed the feat/3033-deploy-by-name branch from 298530f to d84695d Compare February 26, 2022 17:39
@tinfoil-knight tinfoil-knight requested review from erezrokah and removed request for a team February 26, 2022 17:46
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Another great PR, @tinfoil-knight ❤️

@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Mar 1, 2022
@kodiakhq kodiakhq bot merged commit 84b98e5 into netlify:main Mar 1, 2022
@tinfoil-knight tinfoil-knight deleted the feat/3033-deploy-by-name branch March 2, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploying by site name Regression: cannot provide human-readable site name
2 participants