-
Notifications
You must be signed in to change notification settings - Fork 394
fix: implement fallbacks to fix terminal-link vscode hyperlinks #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with e9c1789 Package size: 380 MB⬇️ 0.00% decrease vs. e9c1789
Legend
|
ehmicky
reviewed
Mar 15, 2022
…ify/cli into fix/terminal-link-vscode-hyperlinks
ehmicky
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks @wangoimacharia!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #4311
netlify dev
VSCode links for loaded functions render invalid links for cmd/ctrl clicked links because the characters%E2%80%8B
are added to the end of the URL due to a zero width space provision onterminal-link
.This PR adds a fallback function to be ran in unsupported terminals allowing us to define how those links should be rendered. e.g
terminalLink(text, url, { fallback: () => `${text} ${url}` })
. This fixes VSCode hyperlinks while allowing us to still use terminalLink for unsupported terminals.Screenshots:

VSCode:
PowerShell:

iTerm:

For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
Photo by James Watson on Unsplash