Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bootstrap latest to use latest version of bootstrap #146

Merged
merged 2 commits into from Oct 3, 2022

Conversation

khendrikse
Copy link
Contributor

Which problem is this pull request solving?

Updating to latest version of bootstrap

List other issues or pull requests related to this problem

Getting netlify/cli#4655 ready for production

@khendrikse khendrikse self-assigned this Oct 3, 2022
@khendrikse khendrikse requested a review from a team October 3, 2022 09:06
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 3, 2022
biruwon
biruwon previously approved these changes Oct 3, 2022
@@ -118,7 +118,7 @@ const getLocalEntryPoint = (
return `
try {
const { default: func } = await import("${url}");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, how did this happen? Is the linter no running in the CI? 🤔

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename this to feat: or fix: before merging, otherwise a release won't be generated.

@khendrikse khendrikse changed the title chore: update bootstrap latest to use latest version of bootstrap feat: update bootstrap latest to use latest version of bootstrap Oct 3, 2022
@khendrikse khendrikse added type: feature code contributing to the implementation of a feature and/or user facing functionality and removed type: chore work needed to keep the product and development running smoothly labels Oct 3, 2022
@khendrikse khendrikse merged commit 9aef2f7 into main Oct 3, 2022
@khendrikse khendrikse deleted the chore/update-bootstrap-lates branch October 3, 2022 09:44
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
…lify/edge-bundler#146)

* chore: update bootstrap latest to use latest version of bootstrap

* chore: update bootstrap to the correct latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants