Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run config export with --allow-env #174

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

When invoking the edge function at build time to resolve the config export, we should call the Deno CLI with --allow-env, otherwise we'll get an error if the function is trying to access Deno.env in the global scope.

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Oct 26, 2022
@eduardoboucas eduardoboucas requested a review from a team October 26, 2022 11:44
Copy link
Member

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eduardoboucas eduardoboucas merged commit 6020add into main Oct 26, 2022
@eduardoboucas eduardoboucas deleted the fix/config-allow-env branch October 26, 2022 12:42
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants