Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct import_map attribute name in validation #241

Merged
merged 5 commits into from Dec 6, 2022
Merged

fix: correct import_map attribute name in validation #241

merged 5 commits into from Dec 6, 2022

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Dec 6, 2022

Follow up to #239, where the schema said importMapURL as the key name instead of import_map which is correct.

@Skn0tt Skn0tt requested a review from a team December 6, 2022 19:41
@Skn0tt Skn0tt added the type: bug code to address defects in shipped code label Dec 6, 2022
@Skn0tt Skn0tt self-assigned this Dec 6, 2022
@Skn0tt
Copy link
Member Author

Skn0tt commented Dec 6, 2022

on my machine, I have do set FORCE_COLOR=0 for the snapshot testing to work correctly. Is it the same for you, @eduardoboucas? If I don't, it outputs a bunch of colour escape codes into the snapshot.

@Skn0tt Skn0tt merged commit dfcd90f into main Dec 6, 2022
@Skn0tt Skn0tt deleted the fix-import-map-property-name branch December 6, 2022 20:25
@token-generator-app token-generator-app bot mentioned this pull request Dec 6, 2022
Merged
@eduardoboucas
Copy link
Member

on my machine, I have do set FORCE_COLOR=0 for the snapshot testing to work correctly. Is it the same for you, @eduardoboucas? If I don't, it outputs a bunch of colour escape codes into the snapshot.

You can also use npm run test:dev:vitest:watch.

@Skn0tt
Copy link
Member Author

Skn0tt commented Dec 6, 2022

good to know! now I see that package.json also has FORCE_COLOR=0, that makes sense :)

Skn0tt added a commit to netlify/build that referenced this pull request Apr 23, 2024
@Skn0tt
fix: correct import_map attribute name in validation (netlify/edge-bu…
082c014 
…ndler#241)

* fix: use correct import_map key for validation

* chore: add test to catch this in the future

* fix: remove unneded type specifier

* fix: imports have to end on .js

* fix: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees

@Skn0tt Skn0tt

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skn0tt @eduardoboucas