Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print nice npm error message for npm: specifier as well #271

Merged
merged 1 commit into from Dec 20, 2022

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Dec 20, 2022

We're already printing a nice error message for npm imports. We should do the same for npm:-prefixed imports.

discovered in https://netlify.slack.com/archives/C02BUDF7A4B/p1671250384449859

@Skn0tt Skn0tt requested a review from a team December 20, 2022 13:23
@Skn0tt Skn0tt added the type: bug code to address defects in shipped code label Dec 20, 2022
@Skn0tt Skn0tt self-assigned this Dec 20, 2022
@Skn0tt Skn0tt merged commit 70071de into main Dec 20, 2022
@Skn0tt Skn0tt deleted the npm-specifier-error branch December 20, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first responder type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants