Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make config export a plain object #273

Merged
merged 1 commit into from Dec 21, 2022
Merged

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Changes the config export to expect a plain object instead of a function that returns an object.

List other issues or pull requests related to this problem

https://github.com/netlify/pod-compute/issues/323#issuecomment-1360564040

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Dec 21, 2022
@eduardoboucas eduardoboucas requested a review from a team December 21, 2022 10:12
@Skn0tt
Copy link
Member

Skn0tt commented Dec 21, 2022

looks like some test is still failing

@eduardoboucas
Copy link
Member Author

Ah, because the Config type in https://edge.netlify.com needs to change. I'll create a PR for that.

@eduardoboucas eduardoboucas merged commit a6a48cf into main Dec 21, 2022
@eduardoboucas eduardoboucas deleted the feat/isc-object branch December 21, 2022 10:37
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants