Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag query to Netlify Identity links #157

Open
erquhart opened this issue Nov 13, 2018 · 6 comments
Open

Add a flag query to Netlify Identity links #157

erquhart opened this issue Nov 13, 2018 · 6 comments
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erquhart
Copy link
Contributor

erquhart commented Nov 13, 2018

This technically isn't an ask for this project, but I'm adding it here for community visibility as it's related to gatsbyjs/gatsby#9565.

Loading the identity widget on every page, especially in an SSG with auto code splitting like Gatsby, often adds unnecessary weight. We should consider adding some sort of flag query to Netlify Identity links so that the widget can be dynamically imported only when necessary. Something like netlify_identity_redirect=true rather than just confirmation_token=xxx, which could technically be from anywhere.

Can we determine if this is feasible or if an alternate approach should be recommended? The PR linked above is an example of what I'd like to help folks avoid, copying internal logic from this repo to determine if the url requires the widget.

@swyxio
Copy link
Contributor

swyxio commented Nov 14, 2018

who is "we" here? i dont know who would own this

@erquhart
Copy link
Contributor Author

Netlify platform. We'd need to update various identity links, such as those in verification emails, to use the flag query, and supporting changes would also potentially occur in this repo. Again, raising here instead of internally because it's a community issue.

Sent with GitHawk

@alexandernanberg
Copy link

alexandernanberg commented Nov 28, 2018

Any updates on this or anything I can contribute to? Would really want to solve this somehow so all the users don't have to load ~50kb (gzipped) extra JS for something they'll never use 😄

@erquhart
Copy link
Contributor Author

Merged your Gatsby PR as a stop gap 👍

@jlengstorf
Copy link
Contributor

@erquhart would this be solved if we didn't have to include the widget on the home page? e.g. if #171 is addressed, does that solve this problem?

@jlengstorf jlengstorf added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 30, 2020
@erquhart
Copy link
Contributor Author

erquhart commented Aug 6, 2020

That would 100% make this request unnecessary 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

4 participants