Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

Commit 8c4b234

Browse files
eduardoboucaskodiakhq[bot]
andauthoredFeb 8, 2022
fix: use safe version of getPackageJson when transpiling ESM (#1008)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
1 parent c7159d7 commit 8c4b234

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed
 

‎src/runtimes/node/bundlers/esbuild/special_cases.ts

+1-11
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,8 @@
1-
import { getPackageJson, PackageJson } from '../../utils/package_json'
1+
import { getPackageJsonIfAvailable, PackageJson } from '../../utils/package_json'
22

33
const EXTERNAL_MODULES = ['@prisma/client']
44
const IGNORED_MODULES = ['aws-sdk']
55

6-
const getPackageJsonIfAvailable = async (srcDir: string): Promise<PackageJson> => {
7-
try {
8-
const packageJson = await getPackageJson(srcDir)
9-
10-
return packageJson
11-
} catch {
12-
return {}
13-
}
14-
}
15-
166
const getModulesForNextJs = ({ dependencies, devDependencies }: PackageJson) => {
177
const allDependencies = { ...dependencies, ...devDependencies }
188
const externalModules = allDependencies.next ? ['critters', 'nanoid'] : []

‎src/runtimes/node/bundlers/nft/es_modules.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { FeatureFlags } from '../../../../feature_flags'
77
import { cachedReadFile, FsCache } from '../../../../utils/fs'
88
import { ModuleFormat } from '../../utils/module_format'
99
import { getNodeSupportMatrix } from '../../utils/node_version'
10-
import { getPackageJson, PackageJson } from '../../utils/package_json'
10+
import { getPackageJsonIfAvailable, PackageJson } from '../../utils/package_json'
1111

1212
import { transpile } from './transpile'
1313

@@ -73,7 +73,7 @@ const processESM = async ({
7373
}
7474
}
7575

76-
const packageJson = await getPackageJson(dirname(mainFile))
76+
const packageJson = await getPackageJsonIfAvailable(dirname(mainFile))
7777
const nodeSupport = getNodeSupportMatrix(config.nodeVersion)
7878

7979
if (featureFlags.zisi_pure_esm && packageJson.type === 'module' && nodeSupport.esm) {

‎src/runtimes/node/utils/package_json.ts

+11-1
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,14 @@ const getPackageJson = async function (srcDir: string): Promise<PackageJson> {
4646
}
4747
}
4848

49-
export { getPackageJson, PackageJson, sanitisePackageJson }
49+
const getPackageJsonIfAvailable = async (srcDir: string): Promise<PackageJson> => {
50+
try {
51+
const packageJson = await getPackageJson(srcDir)
52+
53+
return packageJson
54+
} catch {
55+
return {}
56+
}
57+
}
58+
59+
export { getPackageJson, getPackageJsonIfAvailable, PackageJson, sanitisePackageJson }

1 commit comments

Comments
 (1)

github-actions[bot] commented on Feb 8, 2022

@github-actions[bot]
Contributor

⏱ Benchmark results

largeDepsEsbuild: 8.1s

largeDepsNft: 36.9s

largeDepsZisi: 1m 6.9s

This repository has been archived.