Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds getNodeVersion util #1002

Merged
merged 3 commits into from Feb 7, 2022
Merged

feat: adds getNodeVersion util #1002

merged 3 commits into from Feb 7, 2022

Conversation

eduardoboucas
Copy link
Member

Also moves unit tests into separate files under a test/unit directory, matching the file structure of the files being unit-tested.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 7, 2022
karagulamos
karagulamos approved these changes Feb 7, 2022
View reviewed changes
Copy link

@karagulamos karagulamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kodiakhq kodiakhq bot merged commit b66177d into main Feb 7, 2022
@kodiakhq kodiakhq bot deleted the feat/getnodeversion branch February 7, 2022 13:07
@token-generator-app token-generator-app bot mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karagulamos karagulamos karagulamos approved these changes

Assignees
No one assigned
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardoboucas @karagulamos