feat: generate pure ESM functions for NFT #1004
Conversation
eduardoboucas
added
the
type: feature
| @@ -122,6 +122,7 @@ const bundle: BundleFunction = async ({ | |||
| bundlerWarnings, | |||
| inputs, | |||
| mainFile: normalizedMainFile, | |||
| moduleFormat: 'cjs', | |||
There was a problem hiding this comment.
To be addressed in a follow-up PR.
| export { getBundler } | ||
| // We use ZISI as the default bundler, except for certain extensions, for which | ||
| // esbuild is the only option. | ||
| const getDefaultBundler = async ({ |
There was a problem hiding this comment.
This function was moved from src/runtimes/node/index.ts. The code was not changed.
| @@ -42,6 +42,7 @@ const bundle: BundleFunction = async ({ | |||
| basePath: getBasePath(dirnames), | |||
| inputs: srcFiles, | |||
| mainFile, | |||
| moduleFormat: 'cjs', | |||
There was a problem hiding this comment.
To be addressed in a follow-up PR.
| // `adm-zip` and `require()` expect Unix paths. | ||
| // We remove the common path prefix. | ||
| // With files on different Windows drives, we remove the drive letter. | ||
| const normalizeFilePath = function ({ |
There was a problem hiding this comment.
Moved unchanged from src/runtimes/node/utils/zip.ts.
| }): Promise<NodeBundlerName> => { | ||
| const { defaultEsModulesToEsbuild, traceWithNft } = featureFlags | ||
|
|
||
| if (['.mjs', '.ts'].includes(extension)) { |
There was a problem hiding this comment.
Note for a future PR: maybe we should support *.mts too.
|
|
||
| t.true(functionsAreESM.every(Boolean)) | ||
| }, | ||
| ) |
tests/main.js
Outdated
| await unzipFiles(files, (path) => `${path}/../${basename(path)}_out`) | ||
|
|
||
| const functionPaths = [join(tmpDir, 'func1.zip_out', 'func1.js'), join(tmpDir, 'func2.zip_out', 'func2.js')] | ||
| const func1 = await import(functionPaths[0]) |
There was a problem hiding this comment.
pathToFileURL() must be used.
Maybe you can cherry pick the following test helper from another pending PR? https://github.com/netlify/zip-it-and-ship-it/pull/980/files#diff-91254b3a8e85bba2e8bad93724729fcd3531241f5b57196acc1e49db3e856a49R113
This is because import() argument is a URI, not a file path (unlike require()).
On Windows, absolute file paths like C:\... are not valid URLs. Also, URIs are percent-encoded, so this would also fail for file paths with characters which would normally be percent-encoded.
There was a problem hiding this comment.
Thank you! Done in 7156614.
Summary
As of last month, AWS Lambda supports native ESM functions. Currently, we're unable to take advantage of this functionality since zip-it-and-ship-it always generates CJS functions.
This PR starts changing that by generating pure ESM functions when all of the following conditions are met:
nodeVersionconfiguration property) is greater than or equal to Node 14zisi_pure_esmfeature flag is enabledIn any other scenario, zip-it-and-ship-it continues to transpile ESM and generate CJS functions.