fix(nft): correctly annotate transpilation errors in nft bundler

[danez]

🎉 Thanks for submitting a pull request! 🎉

Summary

Add customErrorInfo to errors happening during transpilation of esm with esbuild in the nft bundler.
I had to loop the function name through to the actual esbuild call, to generate the error location properly.

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻.
  This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
  a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

[eduardoboucas]

Looks great! I left a super minor comment that we usually wouldn't care much about, but since you're new to the codebase I figured it's useful to align on those things.

Also, we tend to use the feedback ladder in PR reviews, hence the [dust] prefix.

[github-actions]

⏱ Benchmark results

Comparing with 61e5b72

largeDepsEsbuild: 6.3s

⬇️ 5.42% decrease vs. 61e5b72

^                                                           9.3s                                          
│                                                           ┌──┐                                          
│                                                           |  |            8.3s                          
│                                                           |  |            ┌──┐                          
│                                                           |  |            |  |                          
│                           6.8s                            |  |            |  |    6.8s                  
│ ──6.5s────────────6.3s────┌──┐────6.6s────6.5s────6.4s────┼──┼────6.5s────┼──┼────┌──┐────6.7s────6.3s──
│   ┌──┐    6.2s    ┌──┐    |  |    ┌──┐    ┌──┐    ┌──┐    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐  
│   |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-26 (61e5b72): 6.6s
• T-25 (43ab287): 6.1s
• T-24 (1e5cd4a): 6.7s
• T-23 (5378020): 6.4s
• T-22 (87e11b4): 9.3s
• T-21 (55679c9): 6.5s
• T-20 (d2d5f28): 6.4s
• T-19 (68765f6): 8.1s
• T-18 (4ac07ab): 7.8s
• T-17 (3287a69): 6.3s
• T-16 (4cad17d): 7.2s
• T-15 (b0da17e): 6.8s
• T-14 (b4a14d8): 6.5s
• T-13 (1ffe7c1): 6.5s
• T-12 (e5d1c7f): 6.5s
• T-11 (400cf3c): 6.2s
• T-10 (b510094): 6.3s
• T-9 (dc0fe1a): 6.8s
• T-8 (ad9161d): 6.6s
• T-7 (1c255c8): 6.5s
• T-6 (7ca3b56): 6.4s
• T-5 (b7a1c35): 9.3s
• T-4 (c64325d): 6.5s
• T-3 (d9a45d8): 8.3s
• T-2 (e666dc1): 6.8s
• T-1 (0a1fe1a): 6.7s
• T (current commit): 6.3s

largeDepsZisi: 44.2s

⬇️ 6.26% decrease vs. 61e5b72

^                                                         1m 14.2s        1m 13.3s                        
│                                                           ┌──┐            ┌──┐                          
│                                                           |  |            |  |                          
│                                                           |  |            |  |                          
│                                                           |  |            |  |                          
│                                  56.4s   54.8s   54.7s    |  |   54.3s    |  |   57.2s                  
│ ─52.8s───51.5s───52.7s───53.3s────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐───52.4s──────────
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |   44.2s  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-26 (61e5b72): 47s
• T-25 (43ab287): 43.6s
• T-24 (1e5cd4a): 48.3s
• T-23 (5378020): 1m 2.9s
• T-22 (87e11b4): 1m 20.5s
• T-21 (55679c9): 1m 2.2s
• T-20 (d2d5f28): 1m 3.2s
• T-19 (68765f6): 1m 11s
• T-18 (4ac07ab): 1m 14.8s
• T-17 (3287a69): 1m 1.5s
• T-16 (4cad17d): 1m 4.8s
• T-15 (b0da17e): 1m 3s
• T-14 (b4a14d8): 1m 1.9s
• T-13 (1ffe7c1): 1m 2.1s
• T-12 (e5d1c7f): 52.8s
• T-11 (400cf3c): 51.5s
• T-10 (b510094): 52.7s
• T-9 (dc0fe1a): 53.3s
• T-8 (ad9161d): 56.4s
• T-7 (1c255c8): 54.8s
• T-6 (7ca3b56): 54.7s
• T-5 (b7a1c35): 1m 14.2s
• T-4 (c64325d): 54.3s
• T-3 (d9a45d8): 1m 13.3s
• T-2 (e666dc1): 57.2s
• T-1 (0a1fe1a): 52.4s
• T (current commit): 44.2s

[eduardoboucas]

🚀

Ah, a final comment about conventions: you're rightly using the fix: prefix to signal a patch update, but there's no need to use the (nft) namespace. We typically only do that for dependency updates (example), which are handled automatically by robots. 🤖