fix: detect a wider range of scheduled functions

[danez]

scheduled functions which are reassigned or not directly exported are now detected

This PR extends the functionality of the detection for the in-source-config of scheduled functions.

2 cases were not supported previously:

1. The schedule is not directly supplied as string to the schedule() helper but assigned to a variable schedule(SCHEDULE, ...)
2. The schedule helper is not directly exported (export const handler = schedule()) but instead assigned to a variable which is exported export { handler }

To solve both of these cases I opted to collect all variable bindings and their current value (only in the root scope). This is done by iterating through all nodes and collecting all declarations of variables and all reassigns. This method is memoized so that multiple calls (at the moment maximum 2) won't result in duplicated work.

Now, when the cron pattern in the schedule helper (1) or the export (2) is encountered as an identifier instead of the expected value, the code now can resolve the identifier to its value using the binding-map.

[github-actions]

⏱ Benchmark results

Comparing with 123e7e8

largeDepsEsbuild: 7.4s

⬆️ 16.91% increase vs. 123e7e8

^                                                                   9.3s                                  
│                                                                   ┌──┐                                  
│   8.3s                                                            |  |                                  
│   ┌──┐            7.7s                                            |  |                    8.1s          
│   |  |            ┌──┐                                            |  |                    ┌──┐    7.4s  
│   |  |            |  |                                            |  |                    |  |    ┌──┐  
│ ──┼──┼────6.4s────┼──┼────6.3s────6.6s────────────6.7s────6.4s────┼──┼────6.5s────6.4s────┼──┼────|▒▒|──
│   |  |    ┌──┐    |  |    ┌──┐    ┌──┐    6.1s    ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (123e7e8): 6.1s
• T-29 (8f964b7): 6.5s
• T-28 (63447f8): 8s
• T-27 (132485e): 7.8s
• T-26 (5aaf915): 7.2s
• T-25 (0dd8174): 7.9s
• T-24 (ab9c0c3): 6.1s
• T-23 (2d99794): 7.5s
• T-22 (7487ac4): 7.9s
• T-21 (716ec4f): 8.2s
• T-20 (830f9f2): 6.3s
• T-19 (0d22eac): 6.5s
• T-18 (846798a): 7.7s
• T-17 (4335698): 8.2s
• T-16 (7e95f8a): 6.1s
• T-15 (4ae024e): 6.3s
• T-14 (e329986): 6.3s
• T-13 (aad5de4): 6.1s
• T-12 (6419b22): 8.3s
• T-11 (f178b2c): 6.4s
• T-10 (eecd8ed): 7.7s
• T-9 (28a85fb): 6.3s
• T-8 (61e5b72): 6.6s
• T-7 (43ab287): 6.1s
• T-6 (1e5cd4a): 6.7s
• T-5 (5378020): 6.4s
• T-4 (87e11b4): 9.3s
• T-3 (55679c9): 6.5s
• T-2 (d2d5f28): 6.4s
• T-1 (68765f6): 8.1s
• T (current commit): 7.4s

largeDepsNft: 35s

^                                                                  44.6s                                  
│                                                                   ┌──┐                                  
│  39.9s           40.5s                                            |  |                                  
│   ┌──┐            ┌──┐                                            |  |                   37.5s          
│   |  |            |  |                                            |  |                    ┌──┐    35s   
│   |  |            |  |                                            |  |                    |  |    ┌──┐  
│ ──┼──┼────────────┼──┼───────────30.7s────────────32s────30.5s────┼──┼───30.2s────31s─────┼──┼────|▒▒|──
│   |  |    28s     |  |   29.1s    ┌──┐            ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |   27.6s    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (123e7e8): n/a
• T-29 (8f964b7): 31.7s
• T-28 (63447f8): 40.7s
• T-27 (132485e): n/a
• T-26 (5aaf915): 34.8s
• T-25 (0dd8174): n/a
• T-24 (ab9c0c3): 30.2s
• T-23 (2d99794): 37.5s
• T-22 (7487ac4): 38.4s
• T-21 (716ec4f): 41.2s
• T-20 (830f9f2): 28.2s
• T-19 (0d22eac): 30.4s
• T-18 (846798a): 35.9s
• T-17 (4335698): 39.1s
• T-16 (7e95f8a): 27.2s
• T-15 (4ae024e): 30.5s
• T-14 (e329986): 28s
• T-13 (aad5de4): 28.1s
• T-12 (6419b22): 39.9s
• T-11 (f178b2c): 28s
• T-10 (eecd8ed): 40.5s
• T-9 (28a85fb): 29.1s
• T-8 (61e5b72): 30.7s
• T-7 (43ab287): 27.6s
• T-6 (1e5cd4a): 32s
• T-5 (5378020): 30.5s
• T-4 (87e11b4): 44.6s
• T-3 (55679c9): 30.2s
• T-2 (d2d5f28): 31s
• T-1 (68765f6): 37.5s
• T (current commit): 35s

largeDepsZisi: 50.4s

^                                                                 1m 20.5s                                
│                                                                   ┌──┐                                  
│                                                                   |  |                   1m 11s         
│                                                                   |  |                    ┌──┐          
│                                                         1m 2.9s   |  |          1m 3.2s   |  |          
│                                                           ┌──┐    |  |  1m 2.2s   ┌──┐    |  |          
│  57.6s           58.3s                                    |  |    |  |    ┌──┐    |  |    |  |          
│ ──┌──┐────────────┌──┐────────────────────────────────────┼──┼────┼──┼────┼──┼────┼──┼────┼──┼───50.4s──
│   |  |            |  |            47s            48.3s    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |   44.1s    |  |   45.1s    ┌──┐   43.6s    ┌──┐    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (123e7e8): n/a
• T-29 (8f964b7): 49s
• T-28 (63447f8): 57.5s
• T-27 (132485e): 55.2s
• T-26 (5aaf915): n/a
• T-25 (0dd8174): 56.8s
• T-24 (ab9c0c3): 44.7s
• T-23 (2d99794): 47.1s
• T-22 (7487ac4): 52.3s
• T-21 (716ec4f): 51.1s
• T-20 (830f9f2): 38.7s
• T-19 (0d22eac): 46.3s
• T-18 (846798a): n/a
• T-17 (4335698): 57.6s
• T-16 (7e95f8a): 43.9s
• T-15 (4ae024e): 46.8s
• T-14 (e329986): 43.7s
• T-13 (aad5de4): 44.4s
• T-12 (6419b22): 57.6s
• T-11 (f178b2c): 44.1s
• T-10 (eecd8ed): 58.3s
• T-9 (28a85fb): 45.1s
• T-8 (61e5b72): 47s
• T-7 (43ab287): 43.6s
• T-6 (1e5cd4a): 48.3s
• T-5 (5378020): 1m 2.9s
• T-4 (87e11b4): 1m 20.5s
• T-3 (55679c9): 1m 2.2s
• T-2 (d2d5f28): 1m 3.2s
• T-1 (68765f6): 1m 11s
• T (current commit): 50.4s

[eduardoboucas]

Looks really good. I left some comments and questions, mostly related to the fact that traversing ASTs is tricky and we should go the extra mile to make sure stuff is easy to understand by our future selves!

[eduardoboucas]

🚀