Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle invalid files entry in package.json #1119

Merged
merged 1 commit into from Jun 21, 2022
Merged

fix: handle invalid files entry in package.json #1119

merged 1 commit into from Jun 21, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Jun 21, 2022

Summary

Fixes netlify/cli#4612

Add more defensive code so that invalid files properties don't make everything explode. See math-utils/hamming-distance#4

@danez danez added the type: bug code to address defects in shipped code label Jun 21, 2022
@danez danez requested a review from a team June 21, 2022 09:03
@github-actions
Copy link
Contributor

⏱ Benchmark results

Comparing with 04a68c8

largeDepsEsbuild: 7.5s

⬆️ 13.67% increase vs. 04a68c8

^           7.5s  
│           ┌──┐  
│ ──────────|▒▒|──
│   6.5s    |▒▒|  
│   ┌──┐    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
└───┴──┴────┴──┴──>
    T-1      T
Legend
  • T-1 (04a68c8): 6.5s
  • T (current commit): 7.5s

largeDepsNft: 38.1s

⬆️ 22.34% increase vs. 04a68c8

^          38.1s  
│           ┌──┐  
│           |▒▒|  
│ ──────────|▒▒|──
│  29.6s    |▒▒|  
│   ┌──┐    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
└───┴──┴────┴──┴──>
    T-1      T
Legend
  • T-1 (04a68c8): 29.6s
  • T (current commit): 38.1s

largeDepsZisi: 55.6s

⬆️ 17.20% increase vs. 04a68c8

^          55.6s  
│           ┌──┐  
│           |▒▒|  
│ ──46s─────|▒▒|──
│   ┌──┐    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
│   |  |    |▒▒|  
└───┴──┴────┴──┴──>
    T-1      T
Legend
  • T-1 (04a68c8): 46s
  • T (current commit): 55.6s

eduardoboucas
eduardoboucas approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danez danez merged commit dddd4f8 into main Jun 21, 2022
@danez danez deleted the fix-files-not-array branch June 21, 2022 09:52
@token-generator-app token-generator-app bot mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify cli error when importing imagekit npm package in a netlify funcion
2 participants
@danez @eduardoboucas