Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

feat: zisi system logging #1214

Merged
merged 32 commits into from
Nov 7, 2022
Merged

feat: zisi system logging #1214

merged 32 commits into from
Nov 7, 2022

Conversation

jackiewmacharia
Copy link
Contributor

@jackiewmacharia jackiewmacharia commented Sep 29, 2022

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

This PR adds system logging to ZISI

Related to https://github.com/netlify/pod-compute/issues/196 and https://github.com/netlify/pod-compute/issues/246

Depends on netlify/build#4547


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’».
    This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
    a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@jackiewmacharia jackiewmacharia requested a review from a team September 29, 2022 10:16
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

⏱ Benchmark results

Comparing with 521225e

largeDepsEsbuild: 2.7s

⬆️ 6.14% increase vs. 521225e

^                                                                    3s                           
β”‚                                                   2.9s            β”Œβ”€β”€β”                          
β”‚                                                   β”Œβ”€β”€β”            |  |                    2.7s  
β”‚           2.6s            2.5s                    |  |            |  |    2.5s    2.5s    β”Œβ”€β”€β”  
β”‚           β”Œβ”€β”€β”            β”Œβ”€β”€β”                    |  |    2.5s    |  |    β”Œβ”€β”€β”    β”Œβ”€β”€β”    |β–’β–’|  
β”‚ ──────────┼──┼────────────┼──┼────────────2.2sβ”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€|β–’β–’|──
β”‚   2.1s    |  |    2.1s    |  |    2.1s    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   β”Œβ”€β”€β”    |  |    β”Œβ”€β”€β”    |  |    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 13.9s

⬆️ 13.12% increase vs. 521225e

^                                                                  15.5s                          
β”‚                                                  14.8s            β”Œβ”€β”€β”                          
β”‚          14.2s                                    β”Œβ”€β”€β”            |  |                   13.9s  
β”‚           β”Œβ”€β”€β”                                    |  |            |  |                    β”Œβ”€β”€β”  
β”‚           |  |           12.4s                    |  |            |  |    12s    12.1s    |β–’β–’|  
β”‚ β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€11.9sβ”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€|β–’β–’|──
β”‚           |  |            |  |            11s     |  |    β”Œβ”€β”€β”    |  |    |  |    |  |    |β–’β–’|  
β”‚           |  |    9.8s    |  |   10.1s    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   9.4s    |  |    β”Œβ”€β”€β”    |  |    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 19.4s

⬆️ 5.84% increase vs. 521225e

^                                                                  22.5s                          
β”‚                                                  21.3s            β”Œβ”€β”€β”                          
β”‚                                                   β”Œβ”€β”€β”            |  |                          
β”‚          19.7s           18.6s                    |  |            |  |                   19.4s  
β”‚           β”Œβ”€β”€β”            β”Œβ”€β”€β”                    |  |    18s     |  |   18.4s   18.3s    β”Œβ”€β”€β”  
β”‚ β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€β”Όβ”€β”€β”Όβ”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€β”Œβ”€β”€β”β”€β”€β”€β”€|β–’β–’|──
β”‚           |  |            |  |           16.1s    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚  14.5s    |  |   15.1s    |  |   15.1s    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   β”Œβ”€β”€β”    |  |    β”Œβ”€β”€β”    |  |    β”Œβ”€β”€β”    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
β”‚   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |β–’β–’|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

src/zip.ts Outdated Show resolved Hide resolved
tests/unit/utils/logger.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need sinon anymore, we can use vitest directly.

tests/unit/utils/logger.test.ts Outdated Show resolved Hide resolved
tests/unit/utils/logger.test.ts Outdated Show resolved Hide resolved
tests/unit/utils/logger.test.ts Outdated Show resolved Hide resolved
tests/unit/utils/logger.test.ts Outdated Show resolved Hide resolved
jackiewmacharia and others added 7 commits October 28, 2022 19:20
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
src/zip.ts Outdated Show resolved Hide resolved
src/zip.ts Outdated Show resolved Hide resolved
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@jackiewmacharia jackiewmacharia enabled auto-merge (squash) November 7, 2022 10:54
@jackiewmacharia jackiewmacharia merged commit bdc8f84 into main Nov 7, 2022
@jackiewmacharia jackiewmacharia deleted the feat/zisi-system-logging branch November 7, 2022 10:59
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants