This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Sep 29, 2022
5 tasks
β± Benchmark resultsComparing with 521225e largeDepsEsbuild: 2.7sβ¬οΈ 6.14% increase vs. 521225e
LegendlargeDepsNft: 13.9sβ¬οΈ 13.12% increase vs. 521225e
LegendlargeDepsZisi: 19.4sβ¬οΈ 5.84% increase vs. 521225e
|
danez
suggested changes
Oct 28, 2022
danez
suggested changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need sinon anymore, we can use vitest directly.
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
eduardoboucas
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
danez
approved these changes
Nov 7, 2022
jackiewmacharia
added
release-please:force-run
and removed
release-please:force-run
labels
Nov 7, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
* feat: zisi system logging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thanks for submitting a pull request! π
Summary
This PR adds system logging to ZISI
Related to https://github.com/netlify/pod-compute/issues/196 and https://github.com/netlify/pod-compute/issues/246
Depends on netlify/build#4547
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire π₯ (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)