Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

feat: return displayName with json config from listFunction, listFunctions and listFunctionsFiles #1329

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Jan 31, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Because we want to be able to show the display name in the cli when running netlify dev we need to return the displayname from listFunction, listFunctions and listFunctionsFiles.

Connected issue: https://github.com/netlify/pod-compute/issues/373


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻.
    This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
    a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…tions and listFunctionsFiles
@khendrikse khendrikse added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 31, 2023
@khendrikse khendrikse requested a review from a team January 31, 2023 10:30
@khendrikse khendrikse self-assigned this Jan 31, 2023
@github-actions
Copy link
Contributor

⏱ Benchmark results

Comparing with 166ea95

largeDepsEsbuild: 2.2s

⬆️ 1.21% increase vs. 166ea95

^                                            3s                   
│                                           ┌──┐                  
│                   2.7s    2.6s            |  |                  
│           2.5s    ┌──┐    ┌──┐            |  |                  
│           ┌──┐    |  |    |  |            |  |                  
│ ──────────┼──┼────┼──┼────┼──┼────────────┼──┼────2.2s────2.2s──
│   2.1s    |  |    |  |    |  |     2s     |  |    ┌──┐    ┌──┐  
│   ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 8.6s

⬇️ 1.68% decrease vs. 166ea95

^                                          11.7s                  
│                                           ┌──┐                  
│                                           |  |                  
│                   9.9s    10s             |  |                  
│           9.6s    ┌──┐    ┌──┐            |  |                  
│ ──────────┌──┐────┼──┼────┼──┼────────────┼──┼────8.8s────8.6s──
│    8s     |  |    |  |    |  |            |  |    ┌──┐    ┌──┐  
│   ┌──┐    |  |    |  |    |  |    7.6s    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 16.1s

⬇️ 0.22% decrease vs. 166ea95

^                                          21.5s                  
│                                           ┌──┐                  
│                          19.3s            |  |                  
│          18.6s    18s     ┌──┐            |  |                  
│           ┌──┐    ┌──┐    |  |            |  |                  
│ ──────────┼──┼────┼──┼────┼──┼────────────┼──┼───16.2s───16.1s──
│  15.6s    |  |    |  |    |  |   14.8s    |  |    ┌──┐    ┌──┐  
│   ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@khendrikse khendrikse merged commit 7ca62fe into main Jan 31, 2023
@khendrikse khendrikse deleted the feat-373/pass-displayname-through-json-config-in-listfunctions branch January 31, 2023 10:45
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants