This repository was archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
feat: populate generator field if function is in the internal folder #1357
Merged
khendrikse
merged 3 commits into
main
from
feat/populate-generator-field-when-internal-func
Feb 28, 2023
Merged
feat: populate generator field if function is in the internal folder #1357
khendrikse
merged 3 commits into
main
from
feat/populate-generator-field-when-internal-func
Feb 28, 2023
+47
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with fe2c4a2 largeDepsEsbuild: 2s⬇️ 37.47% decrease vs. fe2c4a2
LegendlargeDepsNft: 7.7s⬇️ 39.47% decrease vs. fe2c4a2
LegendlargeDepsZisi: 14.4s⬇️ 39.20% decrease vs. fe2c4a2
|
danez
previously approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny nit
Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
danez
approved these changes
Feb 28, 2023
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…etlify/zip-it-and-ship-it#1357) * feat: populate generator field if function is in the internal folder * Update README.md Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com> --------- Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
I wanted to use our previous logic to populate our generator field if a function is in an internal folder. This way, we don't have to wait for integrations/plugins to populate the generator fields themselves.
Related to: https://github.com/netlify/pod-compute/issues/423
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)