Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

feat: populate generator field if function is in the internal folder #1357

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Feb 27, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

I wanted to use our previous logic to populate our generator field if a function is in an internal folder. This way, we don't have to wait for integrations/plugins to populate the generator fields themselves.

Related to: https://github.com/netlify/pod-compute/issues/423


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻.
    This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
    a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@khendrikse khendrikse added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 27, 2023
@khendrikse khendrikse requested a review from a team February 27, 2023 09:59
@khendrikse khendrikse self-assigned this Feb 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

⏱ Benchmark results

Comparing with fe2c4a2

largeDepsEsbuild: 2s

⬇️ 37.47% decrease vs. fe2c4a2

^                                           2.8s          
│                                           ┌──┐          
│                                           |  |          
│                                           |  |          
│                                           |  |          
│   2.1s     2s      2s                     |  |     2s   
│ ──┌──┐────┌──┐────┌──┐─────2s──────2s─────┼──┼────┌──┐──
│   |  |    |  |    |  |    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 7.7s

⬇️ 39.47% decrease vs. fe2c4a2

^                                          10.8s          
│                                           ┌──┐          
│                                           |  |          
│                                           |  |          
│                                           |  |          
│                           7.8s            |  |          
│ ──7.7s────7.4s────7.4s────┌──┐────7.6s────┼──┼────7.7s──
│   ┌──┐    ┌──┐    ┌──┐    |  |    ┌──┐    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 14.4s

⬇️ 39.20% decrease vs. fe2c4a2

^                                           20s           
│                                           ┌──┐          
│                                           |  |          
│                                           |  |          
│                                           |  |          
│ ──15s─────15s─────15s────14.8s────15s─────┼──┼──────────
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |   14.4s  
│   |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

danez
danez previously approved these changes Feb 28, 2023
Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
@khendrikse khendrikse merged commit 0087f6d into main Feb 28, 2023
@khendrikse khendrikse deleted the feat/populate-generator-field-when-internal-func branch February 28, 2023 16:36
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
…etlify/zip-it-and-ship-it#1357)

* feat: populate generator field if function is in the internal folder

* Update README.md

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>

---------

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants