New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter out double glob-star includedFiles #1546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β± Benchmark resultsComparing with 8277445 largeDepsEsbuild: 3.1sβ¬οΈ 10.46% decrease vs. 8277445
Legend
largeDepsNft: 9.5sβ¬οΈ 17.04% decrease vs. 8277445
Legend
largeDepsZisi: 18.2sβ¬οΈ 15.32% decrease vs. 8277445
Legend
|
minivan
approved these changes
Aug 29, 2023
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thanks for submitting a pull request! π
Summary
Follow-up to #1532. ESbuild doesn't seem to support full glob patterns, but only those that have at most a single glob star in them (see https://github.com/evanw/esbuild/blob/e330bde34251da78eb81be91e583fbfb8318944a/scripts/js-api-tests.js#L2439).
This PR adds handling for those cases to ZISI. We'll start by ignoring those patterns and printing a warning about it. Ignoring a pattern will result in more files being bundled. My gut feeling is that before #1532, some of these files were already bundled anyways, so this shouldn't be a big problem.
After giving a notice to our customers, we'll flip a flag to convert that into a failure.
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire π₯ (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)