New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use ES modules in README.md #978
Conversation
.eslintrc.js
Outdated
files: '*.md/*.js', | ||
parserOptions: { | ||
sourceType: 'module', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround since the top-level repository is not using pure ES modules yet.
To remove once this is not the case anymore.
|
||
return archives | ||
} | ||
const archives = await zipFunctions('functions', 'functions-dist', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pure ES modules come with top-level await
support too.
49ba617
to
10ff409
Compare
Part of #749
This converts the examples in
README.md
to ES modules.For us to review and ship your PR efficiently, please perform the following steps:
π§βπ». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
fixing a typo or something that`s on fire π₯ (e.g. incident related), you can skip this step.
passes our tests.