New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dynamic import()
in tests
#980
Conversation
.eslintrc.js
Outdated
'max-lines-per-function': 'off', | ||
'max-statements': 'off', | ||
'node/global-require': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore after this PR.
@@ -2331,6 +2361,7 @@ test('Creates a manifest file with the list of created functions if the `manifes | |||
}, | |||
}) | |||
|
|||
// eslint-disable-next-line import/no-dynamic-require, node/global-require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#982 replaces those JSON imports with fs.readFile()
+ JSON.parse()
, which will remove those eslint-disable-next-line
comments.
dcf9fed
to
f4056f4
Compare
Part of #749
This replaces
require()
to dynamicimport()
in tests, as part of the migration to ES modules.For us to review and ship your PR efficiently, please perform the following steps:
🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.