fix: fix JSON imports for ES modules #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
changed the title
ehmicky
commented
Jan 28, 2022
.eslintrc.js
Outdated
| @@ -2,6 +2,11 @@ const { overrides } = require('@netlify/eslint-config-node') | |||
|
|
|||
| module.exports = { | |||
| extends: '@netlify/eslint-config-node', | |||
| rules: { | |||
| // This rule enforces using Buffers with `JSON.parse()`. However, TypeScript | |||
| // does not recognize yet that `JSON.parse()` accepts Buffers as argument. | |||
There was a problem hiding this comment.
Due to the above, we pass utf8 when in TypeScript, but not when in JavaScript.
This was referenced Jan 28, 2022
Closed
erezrokah
previously approved these changes
Feb 8, 2022
ehmicky
force-pushed
the
chore/json-imports
branch
from
f529823
to
40cc8de
Compare
erezrokah
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #749
JSON imports with ES modules support in Node.js is still experimental. Therefore, to migrate to ES modules, we need to replace it with doing manual
fs.readFile()+JSON.parse().For us to review and ship your PR efficiently, please perform the following steps:
🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.