Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix shellUtils stubbing with ES modules #983

Merged
merged 3 commits into from Feb 8, 2022
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 28, 2022

Part of #749

ES modules make stubbing harder. More precisely, it is not possible to stub the top-level variable being exporter/imported (either named or default), only its properties. This is, unlike CommonJS, ES modules are linked at parse-time, not runtime.

To workaround this, in order to migrate to pure ES modules, this PR wrap shellUtils into an object, since it is being stubbed in tests.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code
    πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
    fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Jan 28, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky removed the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky mentioned this pull request Jan 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

⏱ Benchmark results

largeDepsEsbuild: 7.3s

^   7.3s  
β”‚   β”Œβ”€β”€β”  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 7.3s

largeDepsNft: 31.1s

^  31.1s  
β”‚   β”Œβ”€β”€β”  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 31.1s

largeDepsZisi: 56.8s

^  56.8s  
β”‚   β”Œβ”€β”€β”  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
β”‚   |β–’β–’|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 56.8s

@kodiakhq kodiakhq bot merged commit dc12508 into main Feb 8, 2022
@kodiakhq kodiakhq bot deleted the chore/shell-utils branch February 8, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants