Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use createRequire() for require.resolve() #986

Merged
merged 2 commits into from Feb 8, 2022
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 28, 2022

Part of #749

When migrating to pure ES modules, require stops being available a global variable. However, we use require.resolve() in this repository. This PR uses createRequire() so require.resolve() remains available even after we migrate to pure ES modules.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code
    🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
    fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Jan 28, 2022
@ehmicky ehmicky changed the title chore: use createRequire() for require.resolve() fix: use createRequire() for require.resolve() Jan 28, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky removed the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky mentioned this pull request Jan 28, 2022
@kodiakhq kodiakhq bot merged commit a941003 into main Feb 8, 2022
@kodiakhq kodiakhq bot deleted the chore/require-resolve branch February 8, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants