New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings improvement: trim ZWSP char #304

Merged

dg merged 2 commits into nette:master from CrazyMuffin:master

Oct 30, 2023

Contributor

CrazyMuffin commented Oct 30, 2023

new feature
BC break? yes - if someone relies on having ZWSP non-trimmed while using default parameter.
doc PR: Not needed, function is covered and does not mention the default characters

Sneaky Zero-Width Space char \u{200B} is currently untrimmed by trim function, while I'd expect it to do so.

Workaround:

Fork or extend the class and overwrite default param
Manually set updated charlist as second argument to every trim() call

CrazyMuffin added 2 commits

October 30, 2023 12:38


          Update Strings: trim ZWSP char

6e50cd5


          Add test comment

df32105

Member

dg commented Oct 30, 2023

Thanks

dg merged commit 4b7b01e into nette:master

12 of 13 checks passed

dg pushed a commit that referenced this pull request


          Strings::trim() trims unicode spaces and ZWSP (#304)

78e3603

dg pushed a commit that referenced this pull request


          Strings::trim() trims unicode spaces and ZWSP (#304)

74618ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment