Circular dependency in boringssl-static/pom.xml

[trustin]

boringssl-static/pom.xml defines the dependencies that depend on themselves: https://github.com/netty/netty-tcnative/blob/netty-tcnative-parent-2.0.52.Final/boringssl-static/pom.xml#L731-L762

I guess the original intention of this dependency is to pull all native libraries for all platforms by just depending on netty-tcnative-boringssl, but it prevents a user from pulling a native library for only one platform by depending on something like netty-tcnative-boringssl:linux-x86_64. It also is a circular dependency which is maybe not desirable:

netty-tcnative-boringssl-static
|
+- netty-tcnative-boringssl-static:linux-x86_64 <---------+
   |                                                      |
   +- netty-tcnative-boringssl-static:windows-x86_64      |
      |                                                   |
      ...|                                                |
         +- netty-tcnative-boringssl-static:linux-x86_64 -+

I didn't look into other netty-tcnative-* POMs, but we'll also have to fix them if they have the same circular dependency.

[ejona86]

@trustin, is it correct to say you aren't using Maven? See #716 where we talk about Gradle and Bazel impacted by this. This is because of the classifiers; apparently classifiers are interpreted differently in other systems vs Maven.

[varming]

Looks like the Bazel issue was fixed in bazelbuild/rules_jvm_external@d2c7811

[tkowalcz]

FWIW I have recently also encountered this in maven. For each platform we support I need to do this:

<dependency>
  <groupId>io.netty</groupId>
  <artifactId>netty-tcnative-boringssl-static</artifactId>
  <version>2.0.60.Final</version>
  <classifier>osx-aarch_64</classifier>

  <exclusions>
    <exclusion>
      <groupId>io.netty</groupId>
      <artifactId>netty-tcnative-boringssl-static</artifactId>
    </exclusion>
  </exclusions>
</dependency>

[fangpenlin]

I ran into maven hanging problem, then ran a dependencies analytics and found the following circular dependencies diagram:

Not 100% sure that's the cause of our maven command hanging, still looking, but just FYI.

[trustin]

@trustin, is it correct to say you aren't using Maven? See #716 where we talk about Gradle and Bazel impacted by this. This is because of the classifiers; apparently classifiers are interpreted differently in other systems vs Maven.

Correct. It was Bazel at that time.

[conet]

The same happens with sbt I had a hard time to figure out why the native libraries from all platforms were pulled in although the classifier "linux-x86_64" was specified. Now I need to add an exclusion to solve this:

"io.netty" % "netty-tcnative-boringssl-static" % "2.0.61.Final" classifier "linux-x86_64" exclude("io.netty", "netty-tcnative-boringssl-static")