New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client side socket.io cannot be configured to accept path options #307
Comments
PR welcome, you can maybe add a |
For |
Your need was for the socketio adapter, but I had the same question for the easyrtc adapter on slack. The easyrtc adapter is using the open-easyrtc lib that uses also socketio, so in the end it's the same. In networked-aframe/src/adapters/EasyRtcAdapter.js Lines 39 to 41 in ec505fb
you can probably try replacing by
and call |
Hello @vincentfretin I am using the socket.io with easyrtc adapter and I want to add path through options. Can you help? |
I don't have the bandwidth to help on this particular issue in the coming weeks. What I described may not work? Do you folks have already successfully configured a simple express nodejs server using socketio (no naf at all) with what you're trying to do? In which context do you need to host at a specific path? You're using your own VM, nginx in front? |
Hello @vincentfretin, I have figured out the why the websocket connection is not giving 101 switching protocols response. Thanks to you. |
I wrote a guide for configuring nginx in front of janus ws in a VM https://github.com/networked-aframe/naf-janus-adapter/blob/master/docs/janus-deployment.md#nginx-configuration that may help you? |
I'm trying to use networked-aframe with socket.io on a context path eg localhost:8080/my-app. But how can I configure the client-side socket.io part with that path as it goes by default to localhost:8080/socket.io? Seems it's not configurable as I'm not seeing a second param being passed into the socket.io constructor with path as a field in https://github.com/networked-aframe/networked-aframe/blob/master/src/adapters/naf-socketio-adapter.js#L71
AFAIK, it should be something like const socket = self.socket = io(self.wsUrl, {path: myPath});
or make all options configurable instead of just path.
The text was updated successfully, but these errors were encountered: