Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't connect to a room without camera (easyrtc adapter) #374

Open
vincentfretin opened this issue Oct 29, 2022 · 5 comments
Open

Can't connect to a room without camera (easyrtc adapter) #374

vincentfretin opened this issue Oct 29, 2022 · 5 comments

Comments

@vincentfretin
Copy link
Member

With the easyrtc adapter with video:true, like in the example
https://naf-examples.glitch.me/basic-video.html
If a user refuse the camera permission, it gives "DOMException: The request is not allowed by the user agent or the platform in the current context." and doesn't connect to the room, you're alone.
On a VR headset, you don't have a camera, so you can't connect to the room at all.

@vincentfretin
Copy link
Member Author

As I commented in #372 (comment)
The app should use the addLocalMediaStream(stream, streamName) api to set the camera stream and we should stop getting the camera stream automatically from the adapter before we connect, this should be the fix for this issue.

@vincentfretin
Copy link
Member Author

And in this breaking change, networked-scene video:true option won't be used anymore.

@kylebakerio
Copy link
Member

I wonder if this is a regression; in an older project of mine, I don't seem to have this issue.

@vincentfretin
Copy link
Member Author

If it's an old project with networked-aframe 0.7.1 before we implement camera sharing, then you don't have the issue.

@vincentfretin
Copy link
Member Author

You can sponsor $100 to vincentfretin to expedite this fix. Find other work you can sponsor at https://github.com/c-frame/sponsorship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants