Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dynamic initialization" linking error when combining Menu::style and using rotaryEventIn.h #412

Open
keldonin opened this issue Mar 22, 2023 · 0 comments

Comments

@keldonin
Copy link
Collaborator

A linkage error occurs when using rotaryEnventIn.h in combination with combined Menu::style:

In this example, the combination

#include <menuIO/rotaryEventIn.h>

...

MENU(saveConfigSubMenu, "Save config", Menu::doNothing, Menu::noEvent, Menu::noStyle | Menu::showTitle,
  OP("OK", saveConfig, enterEvent),
  EXIT("<Cancel")
);

This is likely caused by this lines (amongst other) inside rotaryEventIn.h:

template<class T> inline T operator| (T a, T b) { return (T)((int)a | (int)b); }

As generic programming in this case tend to apply to all enums or classes using an overloaded operator. One can also question if an enumeration is the right object for a bit set?

Anyways, compiler and linker seem happy when generic overloaded operations are declared as constexpr.

PR to follow.

keldonin added a commit to keldonin/ArduinoMenu that referenced this issue Mar 22, 2023
neu-rah added a commit that referenced this issue Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant