Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Rename pipelines and centralise the security ones #33

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

kilokang
Copy link
Contributor

As the first iteration to standardize the pipelines, I need all the pipelines to be named the same way

I'll need to run scripts to analyze them such as diff and yq to see the differences between them and having them with different names makes the scripts a mess.

This is the bare minimum start even if the effort to standardize the pipelines finally does not happen.

This PR also renames the reusable pipelines with the prefix reusable_ so we can have more readable pipelines as this repository is expected to grow a lot in the near future.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kilokang kilokang requested a review from a team November 17, 2023 11:06
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -1,7 +1,7 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
"config:recommended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new pipeline that I have added and that I have added here: https://github.com/newrelic/coreint-automation/pull/33/files#diff-efda70da6ee709cf755707663c052d5f163fa082bb1e6c441fb08cd36d3341f5R24

Renovate bot changed that and the bot complained that "base" does not exist anymore and that it is being migrated to "recommended".

I changed it to have a cleaner CI run.

@marcsanmi marcsanmi requested a review from a team November 17, 2023 12:20
@kilokang kilokang requested review from sigilioso, marcsanmi and a team and removed request for marcsanmi November 17, 2023 13:52
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kilokang kilokang merged commit 7ba95d5 into main Nov 20, 2023
@kilokang kilokang deleted the chore/standartise-pipelines/rename-all-pipelines branch November 20, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants