Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guided Installer is appending unnecessary labels to config file #1543

Open
neilpdx opened this issue Dec 31, 2023 · 0 comments
Open

Guided Installer is appending unnecessary labels to config file #1543

neilpdx opened this issue Dec 31, 2023 · 0 comments

Comments

@neilpdx
Copy link

neilpdx commented Dec 31, 2023

Description

Every time the Guided Installer is run, it appends <labels>nr_deployed_by:newrelic-cli</labels> to the newrelic.config file for the .NET agent.

After many installs, the config file could look like this:

<labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels> <labels>nr_deployed_by:newrelic-cli</labels></configuration>

This could potentially cause issues over time and makes the config file longer than it should be and makes it harder to read/parse.

Go Version

Provide the output of go version here please

Current behavior

The label is added for every install.

Expected behavior

The label should only be added to the config file once.

Steps To Reproduce

Run the guided installer and note that <labels>nr_deployed_by:newrelic-cli</labels> is appended right before the closing </configuration> tag.

Run the guided installer again and note that a duplicate label is appended.

Debug Output (if applicable)

If applicable, add associated log output to help explain the problem.

Additional Context

Add any other context about the problem here.

References or Related Issues

Are there any other related GitHub issues (open or closed) or Pull Requests that should be linked here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant