Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values for attributes that should have a default value #72

Open
sanderblue opened this issue May 27, 2020 · 0 comments
Open

Add default values for attributes that should have a default value #72

sanderblue opened this issue May 27, 2020 · 0 comments
Labels
enhancement New feature or request kubernetes
Projects
NR1 Developer Toolkit Community

Comments

@sanderblue
Copy link
Contributor

sanderblue commented May 27, 2020 •
edited

Objective

Certain properties of the Alert Policy definition should have default values in case the user doesn't need/want to set them.

As an example, the following properties currently do not have defaults, but maybe they should (loosely based on the relevant Terraform provider schemas).

Policy and NrqlAlertCondition

  • spec.api_key (maybe we can use our env variable with the kubernetes setup?)

NrqlAlertCondition

  • spec.nrql
  • spec.enabled
  • maybe others?
@sanderblue sanderblue added the enhancement New feature or request label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request kubernetes
Projects
No open projects
NR1 Developer Toolkit Community
  
Feature Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpvajda @sanderblue