Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex in ignore_metrics #471

Open
shachar-ash opened this issue Feb 26, 2024 · 1 comment
Open

Support regex in ignore_metrics #471

shachar-ash opened this issue Feb 26, 2024 · 1 comment

Comments

@shachar-ash
Copy link

shachar-ash commented Feb 26, 2024

Description

Currently, when metrics are excluded and we want to add an exception for a subset of metrics, the only option is to add an exception for a prefix.

This is a problem, as it forces us to keep metrics we don't necessarily want. For example, let's look at the following rules:

               ignore_metrics:
                  - prefixes:
                    - 'envoy_'
                    except:
                      - 'envoy_cluster_external_upstream_rq'

In the above example, the only metric I want to keep is envoy_cluster_external_upstream_rq, but when adding this except clause, I am also forced to keep every other metric with the prefix envoy_cluster_external_upstream_rq, so I'll end up having other metrics I don't want, like envoy_cluster_external_upstream_rq_time for example.

Acceptance Criteria

Add regex support, instead of only supporting metrics prefixes.

Estimates

T-shirt size: S = 1-3 days

@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant