Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang specific formatting should be done outside of the schema. #66

Open
zlesnr opened this issue Sep 3, 2020 · 0 comments
Open

Lang specific formatting should be done outside of the schema. #66

zlesnr opened this issue Sep 3, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed pinned Pin an issue to prevent auto-closing by a bot. refactor Code refactoring / cleanup size:M Medium tutone

Comments

@zlesnr
Copy link
Contributor

zlesnr commented Sep 3, 2020

Currently we have a few GetName() methods that wrap the string in a goFormatName in the schema_util code. This however, may not be the desirable place for this modification if we want to start including other languages here. Perhaps it would be better to move this method handling to the lang/golang package and format the names in the generators that use that package, rather than the aiming-to-be-generic code like schema_util.

@jthurman42 jthurman42 added good first issue Good for newcomers help wanted Extra attention is needed pinned Pin an issue to prevent auto-closing by a bot. refactor Code refactoring / cleanup size:M Medium labels Feb 12, 2021
@jpvajda jpvajda added this to Feature Backlog in NR1 Developer Toolkit Community May 24, 2021
@jpvajda jpvajda added the tutone label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed pinned Pin an issue to prevent auto-closing by a bot. refactor Code refactoring / cleanup size:M Medium tutone
Projects
No open projects
Development

No branches or pull requests

3 participants